Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Away from Docker Based action to NodeJS based action #5

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

justinbarclay
Copy link
Member

No description provided.

Clean out old action
@justinbarclay justinbarclay force-pushed the jb/nodejs branch 6 times, most recently from 4cfdff5 to 3d3c3ce Compare June 12, 2024 23:17
@justinbarclay
Copy link
Member Author

@SamDesmondKing this is ready for review.
I think the problem with code-analyzer results is that we don't (or can't) support v3 package-lock.json files in a github action and this repo is written using a v3 package-lock file

@SamDesmondKing
Copy link
Collaborator

I'm sorry I didn't get the chance to look at this today :( feel free to merge if you want to get it in for demo, I'll review tomorrow and can put any suggestions in a new PR, if there are any.

@justinbarclay justinbarclay merged commit 762e909 into main Jun 13, 2024
16 checks passed
@justinbarclay justinbarclay deleted the jb/nodejs branch June 13, 2024 14:08
Copy link
Collaborator

@SamDesmondKing SamDesmondKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Only thing that might need a fixup is a typo in a description, IFF that's exposed to the user.

README.md Show resolved Hide resolved
__tests__/main.test.ts Show resolved Hide resolved
action.yml Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice to have, I think I did this manually here at some point

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still tag manually, which is still easier than running a script. I am not sure the script is long enough for this world, though. People who like using the command line will just use git tag directly, and those who don't will just click the tag/release button.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you have trouble with releasing last time because the process wasn't documented?

src/main.ts Show resolved Hide resolved
@SamDesmondKing
Copy link
Collaborator

SamDesmondKing commented Jun 14, 2024

Also as a thought, since this is public-facing, we may want to use github's release UI rather than tags, that way it's clear for the user when they visit the repo what the latest version is. Right now the latest release is 1.1.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants