-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Away from Docker Based action to NodeJS based action #5
Conversation
Clean out old action
4cfdff5
to
3d3c3ce
Compare
Based off of template from: https://github.com/actions/typescript-action
@SamDesmondKing this is ready for review. |
I'm sorry I didn't get the chance to look at this today :( feel free to merge if you want to get it in for demo, I'll review tomorrow and can put any suggestions in a new PR, if there are any. |
Based off of template from: https://github.com/actions/typescript-action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Only thing that might need a fixup is a typo in a description, IFF that's exposed to the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice to have, I think I did this manually here at some point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still tag manually, which is still easier than running a script. I am not sure the script is long enough for this world, though. People who like using the command line will just use git tag
directly, and those who don't will just click the tag/release button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you have trouble with releasing last time because the process wasn't documented?
No description provided.